This repository was archived by the owner on Feb 4, 2026. It is now read-only.
Add compliant and noncompliant examples of javascript/code-injection@v1.0#71
Open
karmakri wants to merge 5 commits intoaws-samples:mainfrom
Open
Add compliant and noncompliant examples of javascript/code-injection@v1.0#71karmakri wants to merge 5 commits intoaws-samples:mainfrom
karmakri wants to merge 5 commits intoaws-samples:mainfrom
Conversation
zjiamzn
reviewed
Jun 25, 2023
| const allowedParameters = ['-n', '-c'] | ||
|
|
||
| // Compliant: validating user-supplied datas before passing them into the shell command. | ||
| if ( allowedCommands.indexOf(command) != -1 && allowedParameters.indexOf(parameter) != -1 && !isNaN(lines)) { |
There was a problem hiding this comment.
Could you fix indentation:
if (allowedCommands.indexOf(command) != -1)
Note no tailing space after (
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add compliant and noncompliant examples of javascript/code-injection@v1.0.