fix(security): CWE-22 path traversal guard for CLI attachments#183
Merged
Conversation
Introduces safeResolvePath() that validates resolved paths stay within the working directory (CWE-22 mitigation). All path.resolve(userInput) call sites in the attachment upload flow now go through this guard. The single nosemgrep suppression is on the guard function itself — it must call path.resolve before it can validate the result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
krokoko
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safeResolvePath()function that validates resolved paths stay within CWD before usepath.resolve(userInput)calls in the attachment upload flownosemgrepsuppression on the guard function itself (must resolve before it can validate)Introduced by PR #176 (attachments feature) — semgrep's
path-join-resolve-traversalrule flagged 3 call sites incli/src/commands/submit.ts.Test plan
tsc --noEmitcompiles cleanlysemgrep scan --config autoreports 0 findings../../etc/passwd) are rejected with clear error🤖 Generated with Claude Code