Skip to content

feat(ci): rename computeVariant to compute_type and apply as resource tag#97

Merged
scottschreckengaust merged 1 commit into
mainfrom
feat/compute-type-tag
May 15, 2026
Merged

feat(ci): rename computeVariant to compute_type and apply as resource tag#97
scottschreckengaust merged 1 commit into
mainfrom
feat/compute-type-tag

Conversation

@scottschreckengaust
Copy link
Copy Markdown
Contributor

Summary

  • Renames computeVariantcompute_type throughout the CI pipeline (build.yml matrix key, env var, cdk.context.json key) to align with the existing ComputeType union type in repo-config.ts
  • CDK app now reads compute_type from context (default: agentcore) and applies it as a resource tag via Tags.of(stack).add('compute_type', computeType)
  • Adds 2 new tests: default value assertion + explicit context value assertion

Closes remaining Phase 2 items in #73.

What changed

File Change
.github/workflows/build.yml matrix.variantmatrix.compute_type; env VARIANTCOMPUTE_TYPE; jq arg/key computeVariantcompute_type
cdk/src/main.ts +3 lines: read compute_type context, apply as tag
cdk/test/stacks/github-tags.test.ts Mirror production logic in helper + 2 new test cases

Test plan

  • github-tags.test.ts — 5/5 pass (3 existing + 2 new)
  • TypeScript compiles clean
  • Pre-commit hooks pass (eslint, gitleaks, yaml check)
  • CI build passes (will verify artifact name is cdk-agentcore-out)

Note: Pre-push security hook has a pre-existing failure (CVE-2026-27135 in libnghttp2 base image) unrelated to this change.

🤖 Generated with Claude Code

… tag

Aligns CI and CDK terminology with the existing ComputeType union in
repo-config.ts. build.yml matrix key, env var, and cdk.context.json key
are all renamed from computeVariant to compute_type. The CDK app now
reads compute_type from context (default: agentcore) and applies it as
a resource tag for per-type baseline diffs and cost attribution.

Closes phase 2 items in #73.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@scottschreckengaust scottschreckengaust added this pull request to the merge queue May 15, 2026
Merged via the queue into main with commit 3a06c20 May 15, 2026
6 checks passed
@scottschreckengaust scottschreckengaust deleted the feat/compute-type-tag branch May 20, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants