fix: allow skipping optional KMS key ARN in evaluator wizard#1402
Merged
Conversation
The TextInput for KMS key ARN was missing `allowEmpty`, preventing Enter from advancing past the step when the field is left empty. Fixes #1398
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1402-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
agentcore-cli-automation
approved these changes
May 27, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Minimal, targeted fix that mirrors the existing pattern in AddDatasetScreen.tsx (allowEmpty alongside a customValidation that already permits empty values). No new feature surface, so no new telemetry needed; the underlying TextInput allowEmpty behavior is already covered by TextInput.test.tsx.
github-actions
Bot
removed
the
agentcore-harness-reviewing
avi-alpert
approved these changes
May 27, 2026
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowEmptyprop to the KMS key ARNTextInputin the add evaluator wizard, allowing users to press Enter to skip the optional fieldRoot Cause
TextInputblocks submission when the value is empty unlessallowEmptyis set. The KMS field is optional but was missing this prop, causing the wizard to freeze at that step.Fixes #1398
Test plan
agentcore add evaluator→ choose LLM-as-a-Judge → complete steps up to KMS key ARN → press Enter with empty field → should advance to confirm step