chore: simplify release-main-and-preview workflow#1415
Conversation
Rename workflow to "Release Main and Preview" to distinguish it from the single-release workflow in the Actions UI. Remove redundant test-main and test-preview jobs since the release PR already triggers build-and-test CI. Confidence: high Scope-risk: narrow
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Package TarballHow to installgh release download pr-1415-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. The rationale is sound — build-and-test.yml and lint.yml both run on PRs to main and cover the same checks (lint, typecheck, build, test:unit) that the removed test-main/test-preview jobs ran, so duplicating them in the release workflow was indeed redundant. The dependency graph cleanup is correct: removing test-main/test-preview from release-approval's needs also makes the if: always() && !failure() && !cancelled() guard unnecessary (it was only needed because those jobs could be skipped per release_target).
One minor thing worth noting (not a blocker): the removed test-preview job did a BUILD_PREVIEW=1 build, which the regular CI doesn't perform. If that build ever breaks, it'll now be caught at publish-preview time rather than before the approval gate. Given that publish-preview performs the same build, this just shifts where the failure surfaces — not a regression in correctness. Worth keeping in mind if preview-specific build issues become a recurring pain point.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Coverage Report
|
3 participants
Summary
test-mainandtest-previewjobs — the release PR already triggersbuild-and-test.ymlCI, so running lint/typecheck/tests twice is unnecessaryTest plan
dry_run: trueand verify it reaches the approval gate without the removed test jobs