Skip to content

fix: restore --skills invoke override for harness#1418

Merged
jesseturner21 merged 1 commit into
aws:mainfrom
notgitika:fix/invoke-skills-flag
May 28, 2026
Merged

fix: restore --skills invoke override for harness#1418
jesseturner21 merged 1 commit into
aws:mainfrom
notgitika:fix/invoke-skills-flag

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

Summary

  • Restores the --skills CLI flag for agentcore invoke (harness only, preview-gated)
  • Adds skills handling back to buildHarnessBaseOpts() so it's sent to the InvokeHarness API

This was a regression from the preview→main feature flag consolidation. The type field existed in InvokeOptions but was never wired to a CLI flag or action handler.

Test plan

  • TypeScript compiles cleanly
  • Lint/prettier pass
  • Manual: agentcore invoke --harness X --skills ./path/to/skill sends skills in request body

The --skills flag was present on the preview branch but was accidentally
dropped during the preview→main feature flag consolidation. The type
field existed in InvokeOptions but was never wired to a CLI flag or
passed through buildHarnessBaseOpts.

Restores:
- --skills <paths> CLI flag (preview-gated)
- skills handling in buildHarnessBaseOpts to send to InvokeHarness API
@notgitika notgitika requested a review from a team May 28, 2026 20:40
@github-actions github-actions Bot added the size/xs PR size: XS label May 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 28, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.15.0.tgz

How to install

gh release download pr-1418-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. The fix is small, focused, and follows the same pattern as the other harness override flags wired through buildHarnessBaseOpts (e.g. --tools, --allowed-tools):

  • The CLI flag is correctly preview-gated alongside the other harness overrides in command.tsx.
  • The { path: string } shape produced in buildHarnessBaseOpts matches the HarnessSkill interface in agentcore-harness.ts and the deploy-time mapSkills mapper, so wire format is consistent.
  • Both invoke paths (handleHarnessInvokeByArn and the named-harness handler) route through buildHarnessBaseOpts, so the override applies in both cases.
  • InvokeOptions.skills already existed in types.ts, confirming this was a wiring regression as described.

Telemetry-wise, this is consistent with the other harness override flags (none of --tools, --system-prompt, --allowed-tools, --max-iterations, etc. are individually tracked in InvokeAttrs), so no new telemetry is needed here.

One non-blocking note: the test plan still has "Manual: agentcore invoke --harness X --skills ./path/to/skill sends skills in request body" unchecked — worth running that end-to-end before merging to confirm the round-trip works.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 28, 2026
@jesseturner21 jesseturner21 merged commit 285b010 into aws:main May 28, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants