fix: restore --skills invoke override for harness#1418
Merged
Conversation
The --skills flag was present on the preview branch but was accidentally dropped during the preview→main feature flag consolidation. The type field existed in InvokeOptions but was never wired to a CLI flag or passed through buildHarnessBaseOpts. Restores: - --skills <paths> CLI flag (preview-gated) - skills handling in buildHarnessBaseOpts to send to InvokeHarness API
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1418-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
agentcore-cli-automation
approved these changes
May 28, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good to merge. The fix is small, focused, and follows the same pattern as the other harness override flags wired through buildHarnessBaseOpts (e.g. --tools, --allowed-tools):
- The CLI flag is correctly preview-gated alongside the other harness overrides in
command.tsx. - The
{ path: string }shape produced inbuildHarnessBaseOptsmatches theHarnessSkillinterface inagentcore-harness.tsand the deploy-timemapSkillsmapper, so wire format is consistent. - Both invoke paths (
handleHarnessInvokeByArnand the named-harness handler) route throughbuildHarnessBaseOpts, so the override applies in both cases. InvokeOptions.skillsalready existed intypes.ts, confirming this was a wiring regression as described.
Telemetry-wise, this is consistent with the other harness override flags (none of --tools, --system-prompt, --allowed-tools, --max-iterations, etc. are individually tracked in InvokeAttrs), so no new telemetry is needed here.
One non-blocking note: the test plan still has "Manual: agentcore invoke --harness X --skills ./path/to/skill sends skills in request body" unchecked — worth running that end-to-end before merging to confirm the round-trip works.
jesseturner21
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skillsCLI flag foragentcore invoke(harness only, preview-gated)buildHarnessBaseOpts()so it's sent to the InvokeHarness APIThis was a regression from the preview→main feature flag consolidation. The type field existed in
InvokeOptionsbut was never wired to a CLI flag or action handler.Test plan
agentcore invoke --harness X --skills ./path/to/skillsends skills in request body