add units for control plane metrics#824
Merged
Conversation
nathalapooja
approved these changes
Aug 24, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 57.58% 60.01% +2.42%
==========================================
Files 370 351 -19
Lines 17548 17933 +385
==========================================
+ Hits 10105 10762 +657
+ Misses 6848 6596 -252
+ Partials 595 575 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mitali-salvi
approved these changes
Aug 24, 2023
SaxyPandaBear
approved these changes
Aug 24, 2023
jefchien
added a commit
that referenced
this pull request
Oct 3, 2024
jefchien
added a commit
that referenced
this pull request
Oct 3, 2024
jefchien
added a commit
that referenced
this pull request
Oct 4, 2024
jefchien
added a commit
that referenced
this pull request
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Enhanced container insights control plane metrics do not have units.
Description of changes
The prometheus receiver that ingests these metrics does not assign them units. We can add units by correctly configuring the EMF exporter
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint