Skip to content

add units for control plane metrics#824

Merged
chadpatel merged 1 commit intoaws:mainfrom
chadpatel:control-plane-metrics-units
Aug 24, 2023
Merged

add units for control plane metrics#824
chadpatel merged 1 commit intoaws:mainfrom
chadpatel:control-plane-metrics-units

Conversation

@chadpatel
Copy link
Contributor

Description of the issue

Enhanced container insights control plane metrics do not have units.

Description of changes

The prometheus receiver that ingests these metrics does not assign them units. We can add units by correctly configuring the EMF exporter

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Screen Shot 2023-08-24 at 12 25 12 PM
Screen Shot 2023-08-24 at 12 26 23 PM
Screen Shot 2023-08-24 at 12 26 38 PM

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@chadpatel chadpatel requested a review from a team as a code owner August 24, 2023 17:54
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.01%. Comparing base (96d4763) to head (dba299f).
⚠️ Report is 974 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   57.58%   60.01%   +2.42%     
==========================================
  Files         370      351      -19     
  Lines       17548    17933     +385     
==========================================
+ Hits        10105    10762     +657     
+ Misses       6848     6596     -252     
+ Partials      595      575      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants