Pass IDE trusted system certs to Language server by default#482
Merged
shruti0085 merged 2 commits intomainfrom Jul 16, 2025
Merged
Pass IDE trusted system certs to Language server by default#482shruti0085 merged 2 commits intomainfrom
shruti0085 merged 2 commits intomainfrom
Conversation
rli
approved these changes
Jul 11, 2025
| } | ||
|
|
||
| try { | ||
| String pemContent = ProxyUtil.getCertificatesAsPem(); |
There was a problem hiding this comment.
this is probably fine, but since eclipse does not really have dynamic certificate mutation it is probably safe to make one copy for the IDE session
| if (StringUtils.isEmpty(pemContent)) { | ||
| return null; | ||
| } | ||
| Activator.getLogger().info("Injecting IDE trusted certificates into NODE_EXTRA_CA_CERTS"); |
| pemEntries.add(encodedCert); | ||
| pemEntries.add("-----END CERTIFICATE-----"); | ||
| } catch (Exception e) { | ||
| Activator.getLogger().error("Failed to encode certificate", e); |
Contributor
Author
There was a problem hiding this comment.
This already does that since the try-catch is within the for loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change improves the proxy support story for the extension. With this, we honor customer CA cert if specified in the preferences UI. If it is not supplied, instead of leaving it blank, we now detect system certificates and send it over to the node based language server. This allows us to address some issues where users are on corporate proxies/firewalls that have a proxy url but not an explicitly defined cert and expects applications to honor system certs.
We currently do the same system cert detection when downloading artifacts for lsp.
Follows a similar approach as JB: aws/aws-toolkit-jetbrains#5553
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.