generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 74
feat(cli): Add hotswap support for QuickSight resources #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
awsmadi
wants to merge
11
commits into
aws:main
Choose a base branch
from
awsmadi:feature/hotswap-quicksight-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
January 22, 2026 18:14
Head branch was pushed to by a user without write access
Use standard sdkDepForLib() helper for flexible version management, allowing package manager deduplication as per repo conventions.
Resolves @smithy/types version conflicts with test infrastructure. Now properly builds without TypeScript compilation errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 87.70% 87.71%
=======================================
Files 72 72
Lines 10102 10102
Branches 1335 1334 -1
=======================================
+ Hits 8860 8861 +1
+ Misses 1217 1216 -1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updates license file to include @aws-sdk/client-quicksight@3.953.0 Fixes CI build error about files changed during build.
ESLint auto-fix alphabetizes imports as required by project style rules. This matches CI expectations and prevents build-time file changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds hotswap deployment support for Amazon QuickSight resources, enabling faster iterative development when working with QuickSight dashboards, analyses, datasets, data sources, and templates.
Motivation
QuickSight resources often require frequent updates during development, particularly when iterating on dashboard definitions, data mappings, and visualizations. Full CloudFormation deployments for these changes can be slow. Hotswap allows developers to bypass CloudFormation and update resources directly
via the AWS API, significantly reducing deployment time during development.
Changes
New QuickSight Hotswap Handler (lib/api/hotswap/quicksight.ts)
Adds hotswap support for five QuickSight resource types:
The implementation:
SDK Integration (lib/api/aws-auth/sdk.ts)
Adds IQuickSightClient interface and quickSight() method to the SDK class with support for:
Hotswap Registration (lib/api/hotswap/hotswap-deployments.ts)
Registers the QuickSight detector for all five resource types in the RESOURCE_DETECTORS map.
Test Infrastructure (test/_helpers/mock-sdk.ts)
Adds mockQuickSightClient for testing QuickSight hotswap operations.
Testing
Added comprehensive test suite (test/api/hotswap/quicksight-hotswap-deployments.test.ts) covering:
Usage Example
bash
Deploy with hotswap enabled - QuickSight changes will be applied directly
cdk deploy --hotswap
Or hotswap-only mode (skip non-hotswappable changes)
cdk deploy --hotswap-fallback
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license