fix(ecs): enableDeploymentAlarms should mutate the alarmNames property #36309
+39
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concat() does not mutate the existing array, while push() does
github-actions
bot
added
beginning-contributor
aws-cdk-automation
requested changes
Dec 5, 2025
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
vito-laurenza-zocdoc
changed the title
Contributor
|
||||||||||||||
Contributor
|
||||||||||||||
vito-laurenza-zocdoc
changed the title
vito-laurenza-zocdoc
changed the title
win-marshall-zocdoc
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #36308
Closes #36308
Reason for this change
Fixes a silent bug in the ecs module.
Description of changes
The code is mistakenly using
concat()which returns a new array rather than modifying the existing one (which was the original intent of the code).Describe any new or updated permissions being added
n/a
Description of how you validated changes
test case added
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license