[v2] Emit handlers before endpoint resolution#8687
Merged
Conversation
Emit `provide-client-params.*` and `before-parameter-build.*` before endpoint resolution. This ports the following botocore pull request: boto/botocore#2920 One update to the endpoint name in the test_signers.py unit test was applied to use the region name in the s3 endpoint, consistent with existing CLI v2 tests.
kdaily
force-pushed
the
event-ordering-params-endpoints-v2
branch
from
5909576 to
d1c0301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This ports the following botocore pull request:
boto/botocore#2920
Description of changes:
Emit
provide-client-params.*andbefore-parameter-build.*before endpoint resolution.One update to the endpoint name in the
test_signers.pyunit test was applied to use the region name (us-east-1) in the s3 endpoint, consistent with existing CLI v2 tests.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.