Skip to content

Increase PyYAML limit as awscli#442

Merged
Mickeypeng merged 1 commit into
aws:masterfrom
mbonfoster:increase-pyyaml-limit
Jul 21, 2023
Merged

Increase PyYAML limit as awscli#442
Mickeypeng merged 1 commit into
aws:masterfrom
mbonfoster:increase-pyyaml-limit

Conversation

@mbonfoster
Copy link
Copy Markdown
Contributor

@mbonfoster mbonfoster commented Jul 17, 2023

Should fix #441

Description of changes:
This PR updates PyYAML limit in order to match with awscli.
aws/aws-cli#8037

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ahmaze
Copy link
Copy Markdown

ahmaze commented Jul 18, 2023

This is the related issue in pyyaml repo: yaml/pyyaml#724

@mbonfoster
Copy link
Copy Markdown
Contributor Author

@Mickeypeng any chance of reviewing/merging this PR?

@justinpincar
Copy link
Copy Markdown

Thank you for the fix! This issue is preventing us from deploying; would love to see this merged soon~

@Mickeypeng
Copy link
Copy Markdown
Contributor

Mickeypeng commented Jul 19, 2023

LGTM what do you think? @NihalM99

Comment thread requirements.txt
@mbonfoster mbonfoster requested a review from chenrui333 July 20, 2023 17:23
@Mickeypeng Mickeypeng requested review from NihalM99 and chenrui333 and removed request for chenrui333 July 20, 2023 18:50
@chenrui333
Copy link
Copy Markdown

chenrui333 commented Jul 21, 2023

actually found a dependency conflict with docker-compose v1

relates to docker/compose#9114

raise an issue, #448

@mbonfoster
Copy link
Copy Markdown
Contributor Author

@Mickeypeng @NihalM99 updates? I think that merging this PR will help many people that's having issues with deployment. Of course it's also necessary to check the conflict with docker-compose that @chenrui333 is mentioning, but merging this PR will help on many other cases.

@gabrielmontenegro-eye
Copy link
Copy Markdown

Thank you on this effort guys. Just reinforcing that this issue is also preventing us from deploying an important hotfix.

@Mickeypeng
Copy link
Copy Markdown
Contributor

Seems like the test failed to run because it was from branch in another repo. Let me pull a new PR for testing, and then I will merge this one.

@Mickeypeng
Copy link
Copy Markdown
Contributor

#449 Same changes passed tests. Merging now

@Mickeypeng Mickeypeng merged commit 87a576d into aws:master Jul 21, 2023
@mbonfoster mbonfoster deleted the increase-pyyaml-limit branch July 21, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eb cli pip install not working

7 participants