Skip to content

Migrate Mqtt5ClientBuilder from deprecated New* to Create* APIs#858

Open
rakshil14-2 wants to merge 3 commits intomainfrom
updating_sample_docs
Open

Migrate Mqtt5ClientBuilder from deprecated New* to Create* APIs#858
rakshil14-2 wants to merge 3 commits intomainfrom
updating_sample_docs

Conversation

@rakshil14-2
Copy link
Copy Markdown

Description of changes:

  • Replaced deprecated New* raw pointer factory methods with Create* shared_ptr
    alternatives in mqtt5_x509, mqtt5_aws_websocket, and mqtt5_pkcs11 samples
  • Updated MIGRATION_GUIDE.md and MQTT5_Userguide.md code examples to use
    Create* APIs with correct types and namespaces

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Copy Markdown
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we've updated some of the samples and READMEs to use the new API, but not all of them. If we're going to make this transition, I'd suggest we update all samples and documentation consistently rather than leaving it partially done.

I understand this is tedious work, so if you feels it's not worth the effort right now, that's a reasonable call. While, if we do want to proceed with the updates, let's make sure we complete them across the board to avoid having a mix of old and new API usage in our examples and Userguide.

Copy link
Copy Markdown
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix & ship

Comment thread documents/MQTT5_Userguide.md Outdated
Comment thread documents/MQTT5_Userguide.md Outdated
Comment thread documents/MQTT5_Userguide.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants