Migrate Mqtt5ClientBuilder from deprecated New* to Create* APIs#858
Open
rakshil14-2 wants to merge 3 commits intomainfrom
Open
Migrate Mqtt5ClientBuilder from deprecated New* to Create* APIs#858rakshil14-2 wants to merge 3 commits intomainfrom
rakshil14-2 wants to merge 3 commits intomainfrom
Conversation
xiazhvera
requested changes
Apr 27, 2026
Contributor
xiazhvera
left a comment
There was a problem hiding this comment.
I noticed we've updated some of the samples and READMEs to use the new API, but not all of them. If we're going to make this transition, I'd suggest we update all samples and documentation consistently rather than leaving it partially done.
I understand this is tedious work, so if you feels it's not worth the effort right now, that's a reasonable call. While, if we do want to proceed with the updates, let's make sure we complete them across the board to avoid having a mix of old and new API usage in our examples and Userguide.
xiazhvera
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
New*raw pointer factory methods withCreate*shared_ptralternatives in mqtt5_x509, mqtt5_aws_websocket, and mqtt5_pkcs11 samples
MIGRATION_GUIDE.mdandMQTT5_Userguide.mdcode examples to useCreate* APIs with correct types and namespaces
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.