Remove the Gemfile.lock from the gem files #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gemfile.lock was removed in #11 but it was missed to be removed from the files being included in the released gem. This is breaking our integration tests and it is still attempting to publish the removed file as part of the gem. `make pr` did not fail as it runs `bundler init` before running the unit and smoke tests. On a clean branch, running `make integ-tests` reproduces the failure.
carlzogh
approved these changes
Jan 22, 2021
stefanbotez
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The Gemfile.lock was removed in #11 but it was missed to be removed from the files being included in the released gem. This is breaking our integration tests and it is still attempting to publish the removed file as part of the gem.
make prdid not fail as it runsbundler initbefore running the unit and smoke tests.On a clean branch, running
make integ-testsreproduces the failure.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.