Skip to content

Conversation

@keshayad
Copy link
Contributor

@keshayad keshayad commented Dec 3, 2020

Description of changes:

  • Added "docker login" for authenticating to dockerHub account while running integration tests. This will fix the docker hub rate limit error while pulling the images.

  • Docker Hub credentials need to be set as CodeBuild environment variables as described in the README's Troubleshooting section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@keshayad keshayad requested review from carlzogh and edhzsz December 3, 2020 11:14
Copy link
Contributor

@edhzsz edhzsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edhzsz edhzsz merged commit e4939c2 into aws:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants