Skip to content

Conversation

@slonm
Copy link

@slonm slonm commented Dec 29, 2021

Allow compile s3-crt on Mingw-w64 toolchain:

  • Changed case of Windows headers to lower case
  • Added undefine WinAPI defines for "interface", "GetObject", "ERROR"
  • removed -fPIC compiler option for Windows
  • Replaced _WIN32 to _MSC_VER or viceversa when needed

- Changed case of Windows headers to lower case
- Added undefine WinAPI defines for "interface", "GetObject", "ERROR"
- removed -fPIC compiler option for Windows
- Replaced _WIN32 to _MSC_VER or viceversa when needed
@slonm slonm closed this Dec 29, 2021
@slonm slonm reopened this Dec 29, 2021
@jmklix jmklix linked an issue Jan 4, 2022 that may be closed by this pull request
@jmklix jmklix added the needs-review This issue or pull request needs review from a core team member. label Jan 4, 2022
@jmklix jmklix closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review This issue or pull request needs review from a core team member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mingw-w64 compilation support

2 participants