Implementing checksum validation for single-part and multipart downloads #3641
+184
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le-part downloads
sbiscigl
reviewed
Dec 9, 2025
| auto hash = handle->GetPartChecksum(partState->GetPartId()); | ||
| if (hash && partState->GetDownloadBuffer()) | ||
| { | ||
| hash->Update(partState->GetDownloadBuffer(), static_cast<size_t>(partState->GetSizeInBytes())); |
Contributor
There was a problem hiding this comment.
lets not do this, in the get object we already validate the checksum of the body i think the idea here is more so the compare the checksum returned from get object, combined across parts, to make sure that the combined object has the same full object checksum.
…into download-checksums
pulimsr
force-pushed
the
download-checksums
branch
2 times, most recently
from
be9c560 to
c469928
Compare
… into download-checksums
pulimsr
force-pushed
the
download-checksums
branch
from
c469928 to
ee58639
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Implemented per-part checksum validation for downloads in TransferManager. Added validateChecksums flag (default: true) to TransferManagerConfiguration. Downloads now validate checksums for both single-part (via file read after download) and multipart transfers (per-part validation). Created GetChecksumFromResult() helper to reduce code duplication. Downloads fail immediately on checksum mismatch.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.