fix(mock): update gomock import path for build compatibility#276
Open
fix(mock): update gomock import path for build compatibility#276
Conversation
Author
|
Hi maintainers 👋, This PR addresses the build inconsistency caused by mismatched ✅ Aligned all references to use Let me know if you'd like this broken into smaller commits or adjusted in any way. Thanks for reviewing and maintaining this project! – @dd-rK |
Author
|
@andresrcs @adrianlzt 🙏 for a quick review when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
make buildandmake testcommands fail due to inconsistent gomock imports:mockgengenerates code that importsgo.uber.org/mock/gomockgithub.com/golang/mock/gomockThis results in type mismatch errors like:
cannot use mockCtrl (type *github.com/golang/mock/gomock.Controller) as *go.uber.org/mock/gomock.Controller
Solution
go.uber.org/mock/gomockImpact