chore(cli): write tpl and params file for aurora and rdws#3022
Merged
mergify[bot] merged 8 commits intoaws:mainlinefrom Nov 12, 2021
Merged
chore(cli): write tpl and params file for aurora and rdws#3022mergify[bot] merged 8 commits intoaws:mainlinefrom
mergify[bot] merged 8 commits intoaws:mainlinefrom
Conversation
efekarakus
requested review from
iamhopaul123
and removed request for
a team
iamhopaul123
approved these changes
Nov 12, 2021
Contributor
iamhopaul123
left a comment
iamhopaul123
left a comment
There was a problem hiding this comment.
LGTM just a very nit comment
| } | ||
|
|
||
| // HiglightCodeBlock wraps the string s with ``` characters, colors it to denote it's a multi-line code block, and returns it. | ||
| func HiglightCodeBlock(s string) string { |
| return "", fmt.Errorf("read 'type' from manifest for %s: %w", o.workloadName, err) | ||
| } | ||
| o.workloadType = t | ||
| return o.workloadType, nil |
Contributor
There was a problem hiding this comment.
We don't need to return the type but just use o.workloadType right? or we abandon o.workloadType this cached variable completely
Contributor
Author
There was a problem hiding this comment.
Refactored! from now we'll call readWorkloadType first in Execute and only refer to the cached variable afterwards
huanjani
added
the
do-not-merge
huanjani
approved these changes
Nov 12, 2021
Contributor
huanjani
left a comment
huanjani
left a comment
There was a problem hiding this comment.
Looks good to me. Added DNM label so you can address PH's Q.
efekarakus
removed
the
do-not-merge
mergify Bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil This PR migrates v2 APIs in `internal/pkg/cli` to use v3. These APIs were introduced in #3022, and were manually tested. If they're run on Lambda, they're likely expected to fail error `[ERR_MODULE_NOT_FOUND]: Cannot find package 'aws-sdk'` after upgrading to Node.js 20 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual testing results in the resource creations.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.