Skip to content

chore: add description for creating Elastic IPs #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
Oct 13, 2022
Merged

chore: add description for creating Elastic IPs #4084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
439c997
chore: add description for creating Elastic IPs
paragbhingre Oct 13, 2022
330fef1
fix integ test
paragbhingre Oct 13, 2022
50496e1
address feedback
paragbhingre Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...al/pkg/deploy/cloudformation/stack/testdata/environments/template-with-basic-manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,6 +480,8 @@ Resources:
SubnetId: !Ref PublicSubnet2

NatGateway1Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 1'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down Expand Up @@ -515,6 +517,8 @@ Resources:
RouteTableId: !Ref PrivateRouteTable1
SubnetId: !Ref PrivateSubnet1
NatGateway2Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 2'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down
4 changes: 4 additions & 0 deletions .../cloudformation/stack/testdata/environments/template-with-custom-empty-security-group.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,8 @@ Resources:
SubnetId: !Ref PublicSubnet2

NatGateway1Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 1'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down Expand Up @@ -206,6 +208,8 @@ Resources:
RouteTableId: !Ref PrivateRouteTable1
SubnetId: !Ref PrivateSubnet1
NatGateway2Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 2'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down
4 changes: 4 additions & 0 deletions ...deploy/cloudformation/stack/testdata/environments/template-with-custom-security-group.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ Resources:
SubnetId: !Ref PublicSubnet2

NatGateway1Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 1'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down Expand Up @@ -217,6 +219,8 @@ Resources:
RouteTableId: !Ref PrivateRouteTable1
SubnetId: !Ref PrivateSubnet1
NatGateway2Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 2'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down
4 changes: 4 additions & 0 deletions ...oy/cloudformation/stack/testdata/environments/template-with-default-access-log-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,8 @@ Resources:
SubnetId: !Ref PublicSubnet2

NatGateway1Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 1'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down Expand Up @@ -572,6 +574,8 @@ Resources:
RouteTableId: !Ref PrivateRouteTable1
SubnetId: !Ref PrivateSubnet1
NatGateway2Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 2'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down
4 changes: 4 additions & 0 deletions ...cloudformation/stack/testdata/environments/template-with-imported-certs-observability.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ Resources:
SubnetId: !Ref PublicSubnet2

NatGateway1Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 1'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down Expand Up @@ -216,6 +218,8 @@ Resources:
RouteTableId: !Ref PrivateRouteTable1
SubnetId: !Ref PrivateSubnet1
NatGateway2Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway 2'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down
2 changes: 2 additions & 0 deletions internal/pkg/template/templates/environment/partials/nat-gateways.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{{- range $ind, $cidr := .PrivateSubnetCIDRs}}
NatGateway{{inc $ind}}Attachment:
Metadata:
'aws:copilot:description': 'An Elastic IP for NAT Gateway {{inc $ind}}'
Type: AWS::EC2::EIP
Condition: CreateNATGateways
DependsOn: InternetGatewayAttachment
Expand Down