chore: Add debug info when an task fails to deploy by KollaAdithya · Pull Request #5249 · aws/copilot-cli

KollaAdithya · 2023-08-29T16:27:53Z

This PR will display the latest 2 stopped tasks and the reasons in the progress tracker.

In case of Essential container exited

In case of Unable to pull secrets

In case of ELB healthCheck failures

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

github-actions · 2023-08-29T16:38:38Z

🍕 Here are the new binary sizes!

Name	New size (kiB)	size (kiB)	Delta (%)
macOS (amd)	51844	51740	+0.20
macOS (arm)	52688	52596	+0.17
linux (amd)	45596	45496	+0.22
linux (arm)	44868	44804	+0.14
windows (amd)	43056	42968	+0.20

codecov-commenter · 2023-08-30T23:57:37Z

Codecov Report

Patch coverage: 83.49% and project coverage change: -0.07% ⚠️

Comparison is base (d54bff6) 69.84% compared to head (9109bff) 69.78%.
Report is 27 commits behind head on mainline.

Additional details and impacted files

@@             Coverage Diff              @@
##           mainline    #5249      +/-   ##
============================================
- Coverage     69.84%   69.78%   -0.07%     
============================================
  Files           296      296              
  Lines         44305    44704     +399     
  Branches        286      286              
============================================
+ Hits          30945    31195     +250     
- Misses        11865    11996     +131     
- Partials       1495     1513      +18

Files Changed	Coverage Δ
internal/pkg/aws/ecs/task.go	`87.64% <50.00%> (+2.35%)`	⬆️
internal/pkg/term/progress/ecs.go	`79.10% <83.09%> (+2.18%)`	⬆️
internal/pkg/stream/ecs.go	`87.82% <86.66%> (-0.28%)`	⬇️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

iamhopaul123 · 2023-08-31T21:24:26Z

For "In case of Essential container exited" it would be great that we include copilot logs command (copilot svc logs --previous or copilot svc logs --tasks xxxxx) as a shortcut for them to view logs (to debug) or an URL to cloudwatch console for that log stream.

CaptainCarpensir

No feedback to give, just a few questions that I'm curious about.

iamhopaul123

Awesome!

Lou1415926

this is such a huge improvement on the UX ❤️ !!

Lou1415926 · 2023-09-08T20:45:50Z

+			Padding: c.padding,
+		},
+		&singleLineComponent{
+			Text: fmt.Sprintf("1. You can run %s to see the logs of the last stopped task.",


quick question - should we always suggest this, or should we suggest this only if a stopped reason is "essential container exit" 🤔 what do you think?

According to this doc , incase of ELB health check failurealso there are suggesting to check for the application logs.

Also there might be a scenario where customers can have print/log statements in the application code, in this case copilot svc logs --previous might be helpful. So I am thinking to include this recommendation for all the cases.

This PR will display the latest 2 stopped tasks and the reasons in the progress tracker. 1. In case of Essential container exited <img width="1043" alt="Screenshot 2023-09-05 at 6 15 06 PM" src="https://github.com/aws/copilot-cli/assets/71282729/3cad713f-cead-4414-8cd8-58b00d9100fe"> 2. In case of Unable to pull secrets <img width="1177" alt="Screenshot 2023-09-05 at 6 26 34 PM" src="https://github.com/aws/copilot-cli/assets/71282729/b7122276-9ac9-4341-8202-875e86f27735"> 3. In case of ELB healthCheck failures <img width="1103" alt="Screenshot 2023-09-05 at 6 55 50 PM" src="https://github.com/aws/copilot-cli/assets/71282729/23dbfe88-328d-4be7-848f-796543f08092"> By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

KollaAdithya added 4 commits August 28, 2023 14:26

change exit codes of svc/env/job deploy

8f509c2

move errstruct to errors.go

8e5b013

stopped task info in the progress tracker

f9f67d4

add tests that ignores scaling activity

08b4a93

KollaAdithya requested a review from a team as a code owner August 29, 2023 16:27

KollaAdithya requested review from huanjani and removed request for a team August 29, 2023 16:27

amazon-ecs-cli-v2-pr-manager requested a review from iamhopaul123 August 29, 2023 16:30

fix tests

54fd468

KollaAdithya marked this pull request as draft August 29, 2023 17:34

KollaAdithya marked this pull request as ready for review August 30, 2023 21:47

add testcase incase of split stopped reasons

fcb8b68

bvtujo added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Aug 31, 2023

Lou1415926 reviewed Aug 31, 2023

View reviewed changes

Comment thread internal/pkg/stream/ecs.go

Comment thread internal/pkg/stream/ecs.go Outdated

bvtujo removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Sep 1, 2023

KollaAdithya marked this pull request as draft September 1, 2023 18:33

CaptainCarpensir reviewed Sep 1, 2023

View reviewed changes

Comment thread internal/pkg/stream/ecs.go Outdated

Comment thread internal/pkg/stream/ecs.go

Comment thread internal/pkg/term/progress/ecs.go

KollaAdithya added 4 commits September 5, 2023 16:20

use shorttask id and use deployment id

435747c

add doc comment

967bc6c

fix doc comment

beae821

collapse taskids incase of same reason

9109bff

KollaAdithya marked this pull request as ready for review September 6, 2023 16:08

add recommended actions

59523b1

iamhopaul123 approved these changes Sep 6, 2023

View reviewed changes

Comment thread internal/pkg/term/progress/ecs.go Outdated

KollaAdithya added 3 commits September 6, 2023 18:55

remove bebug struct and use single comp

8af9adc

addr fb: use map and sort the map

9212a51

add testcase

7d7078a

Lou1415926 reviewed Sep 8, 2023

View reviewed changes

addr @Lou1415926 fb

e287829

Lou1415926 approved these changes Sep 19, 2023

View reviewed changes

Merge branch 'mainline' into render/stoppedtasks

75473a4

mergify Bot merged commit b5e9d5a into aws:mainline Sep 19, 2023

Conversation

KollaAdithya commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iamhopaul123 commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CaptainCarpensir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iamhopaul123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lou1415926 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lou1415926 Sep 8, 2023

Choose a reason for hiding this comment

Uh oh!

KollaAdithya Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KollaAdithya commented Aug 29, 2023 •

edited

Loading

github-actions Bot commented Aug 29, 2023 •

edited

Loading

codecov-commenter commented Aug 30, 2023 •

edited

Loading

iamhopaul123 commented Aug 31, 2023 •

edited

Loading

KollaAdithya Sep 8, 2023 •

edited

Loading