Skip to content

chore: Revert "chore: upgrade lambda and codebuild default runtime from nodejs16.x to nodejs18.x"#5432

Merged
mergify[bot] merged 2 commits intomainlinefrom
revert-5429-upgrade-nodejs
Oct 31, 2023
Merged

chore: Revert "chore: upgrade lambda and codebuild default runtime from nodejs16.x to nodejs18.x"#5432
mergify[bot] merged 2 commits intomainlinefrom
revert-5429-upgrade-nodejs

Conversation

@iamhopaul123
Copy link
Copy Markdown
Contributor

Reverts #5429 because we can't use SDK v2 in our custom resource code. Adopting to SDK v3 takes more effort. Reverting the PR for now to unblock the other PRs.

@iamhopaul123 iamhopaul123 requested review from a team and hkford as code owners October 31, 2023 22:33
@iamhopaul123 iamhopaul123 requested review from huanjani and removed request for a team October 31, 2023 22:33
@iamhopaul123 iamhopaul123 added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Oct 31, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 31, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 52208 51976 +0.45
macOS (arm) 53064 52812 +0.48
linux (amd) 45924 45716 +0.45
linux (arm) 45252 45060 +0.43
windows (amd) 43368 43168 +0.46

@iamhopaul123 iamhopaul123 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Oct 31, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 31, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.91%. Comparing base (cce61ba) to head (64a57b6).
⚠️ Report is 207 commits behind head on mainline.

Additional details and impacted files
@@             Coverage Diff              @@
##           mainline    #5432      +/-   ##
============================================
- Coverage     69.91%   69.91%   -0.01%     
============================================
  Files           299      299              
  Lines         45484    45484              
  Branches        295      295              
============================================
- Hits          31801    31799       -2     
- Misses        12137    12140       +3     
+ Partials       1546     1545       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify mergify Bot merged commit 9c9cf3b into mainline Oct 31, 2023
@mergify mergify Bot deleted the revert-5429-upgrade-nodejs branch October 31, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants