Skip to content

fix: check for ubuntu based distro to install ssm plugin #5571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 6 commits into from
Dec 19, 2023
Merged

fix: check for ubuntu based distro to install ssm plugin #5571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d16929
fix e2e by moving parameter to wkld method
KollaAdithya Dec 12, 2023
278a007
fix ubuntu installation func
KollaAdithya Dec 18, 2023
a386b03
Merge branch 'aws:mainline' into ubuntu/fix/ssm
KollaAdithya Dec 18, 2023
651f1a3
fix tests
KollaAdithya Dec 18, 2023
417ae1a
fix test
KollaAdithya Dec 18, 2023
e9a960d
Merge branch 'mainline' into ubuntu/fix/ssm
mergify[bot] Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions internal/pkg/exec/ssm_plugin_install_latest_binary_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
package exec

import (
"bufio"
"fmt"
"os"
"path/filepath"
Expand Down Expand Up @@ -32,10 +33,31 @@ func (s SSMPluginCommand) InstallLatestBinary() error {
}

func (s SSMPluginCommand) isUbuntu() (bool, error) {
if err := s.runner.Run("uname", []string{"-a"}, Stdout(&s.linuxDistVersionBuffer)); err != nil {
return false, fmt.Errorf("get linux distribution version: %w", err)
if err := s.runner.Run("cat", []string{"/etc/os-release"}, Stdout(&s.linuxDistVersionBuffer)); err != nil {
return false, fmt.Errorf("run cat /etc/os-release: %w", err)
}
return strings.Contains(s.linuxDistVersionBuffer.String(), "Ubuntu"), nil
/*
Example output of /etc/os-release:
"ID=ubuntu"
"ID_LIKE="debian""
*/
scanner := bufio.NewScanner(strings.NewReader(s.linuxDistVersionBuffer.String()))
for scanner.Scan() {
line := scanner.Text()
keyValuePair := strings.SplitN(strings.Trim(strings.TrimSpace(line), `"'`), "=", 2) // Remove potential quotes and newlines.
if len(keyValuePair) != 2 {
continue
}
key := keyValuePair[0]
value := strings.Trim(strings.TrimSpace(keyValuePair[1]), `"'`) // Remove potential quotes and newlines.
if (key == "ID" || key == "ID_LIKE") && strings.Contains(strings.ToLower(value), "ubuntu") {
return true, nil
}
}
if err := scanner.Err(); err != nil {
return false, err
}
return false, nil
}

func (s SSMPluginCommand) installLinuxBinary() error {
Expand Down
57 changes: 51 additions & 6 deletions internal/pkg/exec/ssm_plugin_install_latest_binary_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"errors"
"fmt"
"os"
osexec "os/exec"
"path/filepath"
"testing"

Expand All @@ -27,16 +28,27 @@ func TestSSMPluginCommand_InstallLatestBinary_linux(t *testing.T) {
"return error if fail to check linux distribution": {
setupMocks: func(controller *gomock.Controller) {
mockRunner = NewMockrunner(controller)
mockRunner.EXPECT().Run("uname", []string{"-a"}, gomock.Any()).
mockRunner.EXPECT().Run("cat", []string{"/etc/os-release"}, gomock.Any()).
Return(mockError)
},
wantedError: fmt.Errorf("get linux distribution version: some error"),
wantedError: fmt.Errorf("run cat /etc/os-release: some error"),
},
"return error if fail to install binary on linux": {
linuxVersion: "Linux ip-172-31-35-135.us-west-2.compute.internal 4.14.203-156.332.amzn2.x86_64 #1 SMP Fri Oct 30 19:19:33 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux",
setupMocks: func(controller *gomock.Controller) {
mockRunner = NewMockrunner(controller)
mockRunner.EXPECT().Run("uname", []string{"-a"}, gomock.Any()).Return(nil)
mockRunner.EXPECT().Run("cat", []string{"/etc/os-release"}, gomock.Any()).DoAndReturn(
func(name string, args []string, opts ...CmdOption) error {
cmd := &osexec.Cmd{}
for _, opt := range opts {
opt(cmd)
}
cmd.Stdout.Write([]byte(`
"ID=centos"
"ID_LIKE="rhel fedora""`))
return nil
},
)
mockRunner.EXPECT().Run("sudo", []string{"yum", "install", "-y",
filepath.Join(mockDir, "session-manager-plugin.rpm")}).
Return(mockError)
Expand All @@ -47,7 +59,18 @@ func TestSSMPluginCommand_InstallLatestBinary_linux(t *testing.T) {
linuxVersion: "Linux ip-172-31-0-242 5.4.0-1029-aws #30-Ubuntu SMP Tue Oct 20 10:06:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux",
setupMocks: func(controller *gomock.Controller) {
mockRunner = NewMockrunner(controller)
mockRunner.EXPECT().Run("uname", []string{"-a"}, gomock.Any()).Return(nil)
mockRunner.EXPECT().Run("cat", []string{"/etc/os-release"}, gomock.Any()).DoAndReturn(
func(name string, args []string, opts ...CmdOption) error {
cmd := &osexec.Cmd{}
for _, opt := range opts {
opt(cmd)
}
cmd.Stdout.Write([]byte(`
ID=ubuntu
ID_LIKE="debian"`))
return nil
},
)
mockRunner.EXPECT().Run("sudo", []string{"dpkg", "-i",
filepath.Join(mockDir, "session-manager-plugin.deb")}).
Return(mockError)
Expand All @@ -58,7 +81,18 @@ func TestSSMPluginCommand_InstallLatestBinary_linux(t *testing.T) {
linuxVersion: "Linux ip-172-31-35-135.us-west-2.compute.internal 4.14.203-156.332.amzn2.x86_64 #1 SMP Fri Oct 30 19:19:33 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux",
setupMocks: func(controller *gomock.Controller) {
mockRunner = NewMockrunner(controller)
mockRunner.EXPECT().Run("uname", []string{"-a"}, gomock.Any()).Return(nil)
mockRunner.EXPECT().Run("cat", []string{"/etc/os-release"}, gomock.Any()).DoAndReturn(
func(name string, args []string, opts ...CmdOption) error {
cmd := &osexec.Cmd{}
for _, opt := range opts {
opt(cmd)
}
cmd.Stdout.Write([]byte(`
"ID=centos"
"ID_LIKE="rhel fedora""`))
return nil
},
)
mockRunner.EXPECT().Run("sudo", []string{"yum", "install", "-y",
filepath.Join(mockDir, "session-manager-plugin.rpm")}).
Return(nil)
Expand All @@ -68,7 +102,18 @@ func TestSSMPluginCommand_InstallLatestBinary_linux(t *testing.T) {
linuxVersion: "Linux ip-172-31-0-242 5.4.0-1029-aws #30-Ubuntu SMP Tue Oct 20 10:06:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux",
setupMocks: func(controller *gomock.Controller) {
mockRunner = NewMockrunner(controller)
mockRunner.EXPECT().Run("uname", []string{"-a"}, gomock.Any()).Return(nil)
mockRunner.EXPECT().Run("cat", []string{"/etc/os-release"}, gomock.Any()).DoAndReturn(
func(name string, args []string, opts ...CmdOption) error {
cmd := &osexec.Cmd{}
for _, opt := range opts {
opt(cmd)
}
cmd.Stdout.Write([]byte(`
"ID=pop"
"ID_LIKE="ubuntu debian""`))
return nil
},
)
mockRunner.EXPECT().Run("sudo", []string{"dpkg", "-i",
filepath.Join(mockDir, "session-manager-plugin.deb")}).
Return(nil)
Expand Down