Skip to content

[build][test] upgrade pyyaml to v5.4.1 for n-1 framework version#834

Closed
tejaschumbalkar wants to merge 1 commit into
aws:masterfrom
tejaschumbalkar:upgrade_pyyaml_n-1_version
Closed

[build][test] upgrade pyyaml to v5.4.1 for n-1 framework version#834
tejaschumbalkar wants to merge 1 commit into
aws:masterfrom
tejaschumbalkar:upgrade_pyyaml_n-1_version

Conversation

@tejaschumbalkar
Copy link
Copy Markdown

Issue #, if available:

PR Checklist

  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Pytest Marker Checklist

  • (If applicable) I have added the marker @pytest.mark.model("<model-type>") to the new tests which I have added, to specify the Deep Learning model that is used in the test (use "N/A" if the test doesn't use a model)
  • (If applicable) I have added the marker @pytest.mark.integration("<feature-being-tested>") to the new tests which I have added, to specify the feature that will be tested
  • (If applicable) I have added the marker @pytest.mark.multinode(<integer-num-nodes>) to the new tests which I have added, to specify the number of nodes used on a multi-node test
  • (If applicable) I have added the marker @pytest.mark.processor(<"cpu"/"gpu"/"eia"/"neuron">) to the new tests which I have added, if a test is specifically applicable to only one processor type

EIA/NEURON Checklist

  • When creating a PR:
  • I've modified src/config/build_config.py in my PR branch by setting ENABLE_EI_MODE = True or ENABLE_NEURON_MODE = True
  • When PR is reviewed and ready to be merged:
  • I've reverted the code change on the config file mentioned above

Benchmark Checklist

  • When creating a PR:
  • I've modified src/config/test_config.py in my PR branch by setting ENABLE_BENCHMARK_DEV_MODE = True
  • When PR is reviewed and ready to be merged:
  • I've reverted the code change on the config file mentioned above

Reviewer Checklist

  • For reviewer, before merging, please cross-check:
  • I've verified the code change on the config file mentioned above has already been reverted

Description:

  • Upgrade pyyaml to v5.4.1 due to CVE CVE-2020-14343 affected for versions below v5.4.
  • Framework version: MX1.7 , PT1.6 and TF2.3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment thread mxnet/buildspec.yml
@@ -1,7 +1,9 @@
account_id: &ACCOUNT_ID <set-$ACCOUNT_ID-in-environment>
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temp buildspec changes to build specific framework versions.

@tejaschumbalkar
Copy link
Copy Markdown
Author

Blocked on awscli package dependency for pyyaml < 5.4
Tracker PR awscli/5887

@tejaschumbalkar tejaschumbalkar deleted the upgrade_pyyaml_n-1_version branch February 22, 2021 20:23
tosterberg pushed a commit to tosterberg/deep-learning-containers that referenced this pull request Nov 13, 2023
* Update release_images_inference.yml

* Update release_images_inference.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant