Skip to content

Use botocore.regions EndpointResolver for URL #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdickman-manh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use botocore.regions EndpointResolver for URL #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions git_remote_codecommit/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@
except ImportError:
from urllib.parse import urlparse # python 3.x

# For botocore_EndpointResolver
import inspect
from botocore.regions import EndpointResolver

class FormatError(Exception):
pass
Expand Down Expand Up @@ -174,18 +177,25 @@ def main():

try:
context = Context.from_url(remote_url)
authenticated_url = git_url(context.repository, context.version, context.region, context.credentials)
authenticated_url = git_url(context.session, context.repository, context.version, context.region, context.credentials)
sys.exit(subprocess.call(['git', 'remote-http', git_cmd, authenticated_url]))

except (FormatError, ProfileNotFound, RegionNotFound, CredentialsNotFound, RegionNotAvailable) as exc:
error(str(exc))

def website_domain_mapping(region):
if region in ['cn-north-1', 'cn-northwest-1']:
return 'amazonaws.com.cn'
return 'amazonaws.com'
def botocore_EndpointResolver(service, session, region):
endpoints = session.get_component('data_loader').load_data('endpoints')
construct_endpoint_args = { "service_name": service, "region_name": region }

def git_url(repository, version, region, credentials):
if 'use_dualstack_endpoint' in inspect.getfullargspec(EndpointResolver.construct_endpoint).args:
construct_endpoint_args["use_dualstack_endpoint"] = session.get_config_variable('use_dualstack_endpoint')

if 'use_fips_endpoint' in inspect.getfullargspec(EndpointResolver.construct_endpoint).args:
construct_endpoint_args["use_fips_endpoint"] = session.get_config_variable('use_fips_endpoint')

return EndpointResolver(endpoint_data=endpoints).construct_endpoint(**construct_endpoint_args)['hostname']

def git_url(session, repository, version, region, credentials):
"""
Provides the signed url we can use for pushing and pulling from CodeCommit...

Expand All @@ -201,7 +211,7 @@ def git_url(repository, version, region, credentials):
:return: url we can push/pull from
"""

hostname = os.environ.get('CODE_COMMIT_ENDPOINT', 'git-codecommit.{}.{}'.format(region, website_domain_mapping(region)))
hostname = os.environ.get('CODE_COMMIT_ENDPOINT', 'git-{}'.format(botocore_EndpointResolver('codecommit', session, region)))
path = '/{}/repos/{}'.format(version, repository)

token = '%' + credentials.token if credentials.token else ''
Expand Down