Skip to content

Remove code related to the query editor#864

Merged
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:remove-query-editor
Apr 7, 2025
Merged

Remove code related to the query editor#864
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:remove-query-editor

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Apr 1, 2025

Description

In order to release v1.15 we must remove all code related to the query editor.

Removes

  • Gremlin explorer function for rawQuery and the implementation of the query logic
  • Sparql and openCypher explorer stubs for rawQuery
  • Tab UI in search sidebar panel
  • Query tab component
  • React query definition for rawQuery
  • Query editor feature toggle and related logic
  • Hidden query editor setting UI

Remaining

These are rendered inert with the removal of the above code. Removing these is unnecessary and this functionality can be used beyond the query editor in the future, so they are useful to keep around.

  • Scalar and edge search result row components
  • Mapping logic to parse responses including vertex references and scalar values
  • Edge related logic for adding or removing from graph and checking if already added to graph

Validation

  • Smoke tested locally

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review April 1, 2025 23:50
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 30.18%. Comparing base (46372f5) to head (def259a).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
...plorer/src/modules/SearchSidebar/SearchSidebar.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
+ Coverage   20.96%   30.18%   +9.22%     
==========================================
  Files         523      527       +4     
  Lines       22442    23587    +1145     
  Branches     1198     1358     +160     
==========================================
+ Hits         4704     7119    +2415     
+ Misses      17494    16346    -1148     
+ Partials      244      122     -122     
Flag Coverage Δ
unittests 30.18% <0.00%> (+9.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andreachild
Copy link
Contributor

LGTM

@kmcginnes kmcginnes merged commit 8ba8919 into aws:main Apr 7, 2025
3 of 4 checks passed
@kmcginnes kmcginnes deleted the remove-query-editor branch April 7, 2025 15:00
kmcginnes added a commit to kmcginnes/graph-explorer that referenced this pull request Apr 14, 2025
kmcginnes added a commit to kmcginnes/graph-explorer that referenced this pull request Apr 21, 2025
kmcginnes added a commit to kmcginnes/graph-explorer that referenced this pull request May 14, 2025
kmcginnes added a commit to kmcginnes/graph-explorer that referenced this pull request May 14, 2025
kmcginnes added a commit to kmcginnes/graph-explorer that referenced this pull request May 15, 2025
kmcginnes added a commit that referenced this pull request May 15, 2025
* Revert "Remove code related to the query editor (#864)"

This reverts commit 8ba8919.

* Update changelog
kmcginnes added a commit that referenced this pull request May 20, 2025
* Revert "Remove code related to the query editor (#864)"

This reverts commit 8ba8919.

* Update changelog
kmcginnes added a commit that referenced this pull request May 21, 2025
* Revert "Remove code related to the query editor (#864)"

This reverts commit 8ba8919.

* Update changelog
kmcginnes added a commit that referenced this pull request May 21, 2025
* Revert "Remove code related to the query editor (#864)"

This reverts commit 8ba8919.

* Update changelog
kmcginnes added a commit that referenced this pull request May 22, 2025
* Revert "Remove code related to the query editor (#864)"

This reverts commit 8ba8919.

* Update changelog
kmcginnes added a commit that referenced this pull request May 22, 2025
* Revert "Remove code related to the query editor (#864)"

This reverts commit 8ba8919.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove query editor specific code for release

2 participants