Skip to content

Refine UI around query editor#989

Merged
kmcginnes merged 6 commits intoaws:mainfrom
kmcginnes:add-all-button
Jun 9, 2025
Merged

Refine UI around query editor#989
kmcginnes merged 6 commits intoaws:mainfrom
kmcginnes:add-all-button

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 9, 2025

Description

  • Made "Add All" blue and added icon
  • Removed count from add all since it is redundant
  • Made "Run Query" gray and new icon on right
  • Made "Run Query" button smaller and right aligned
  • Added tooltip to button to show keyboard shortcuts

Validation

refined-sidebar
run-query-tooltip

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review June 9, 2025 15:27
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 9.25926% with 49 lines in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (a899239) to head (16f96b7).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
...rc/modules/SearchSidebar/QuerySearchTabContent.tsx 0.00% 19 Missing ⚠️
...er/src/modules/SearchSidebar/SearchResultsList.tsx 0.00% 12 Missing ⚠️
...-explorer/src/modules/GraphViewer/SelectLayout.tsx 0.00% 10 Missing ⚠️
...ages/graph-explorer/src/components/KeyboardKey.tsx 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   30.72%   33.52%   +2.80%     
==========================================
  Files         525      526       +1     
  Lines       23627    21378    -2249     
  Branches     1408     1522     +114     
==========================================
- Hits         7259     7167      -92     
+ Misses      16241    14093    -2148     
+ Partials      127      118       -9     
Flag Coverage Δ
unittests 33.52% <9.25%> (+2.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kmcginnes kmcginnes merged commit 1b712d9 into aws:main Jun 9, 2025
3 of 4 checks passed
@kmcginnes kmcginnes deleted the add-all-button branch June 9, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "Add All" button more prominent

2 participants