Skip to content

Fix row separator in search results#997

Merged
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:fix-result-row-separator
Jun 12, 2025
Merged

Fix row separator in search results#997
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:fix-result-row-separator

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 12, 2025

Description

The use of borders at the bottom of rows was not rendering properly sometimes. My theory is that some overlapping of elements was occurring. Instead, we use the Tailwind standard way of applying separators, using divide-y divide-{color}. This seems to render properly in all cases.

Other Changes

  • Added separator in edge detail panel between edge representation and properties
  • Tweaked spacing and style of neighbor list header
  • Tweaked spacing of neighbor expansion options
  • Added title to neighbor expansion options section
  • In search results that expand to show attributes (node and edge) I allow the attribute to stretch to the right edge, only indenting on the left
  • Tweaked Label to reduce font weight to baseline since medium was looking a bit heavy

Validation

CleanShot 2025-06-12 at 11 07 46@2x
CleanShot 2025-06-12 at 11 14 43@2x
CleanShot 2025-06-12 at 11 07 32@2x
CleanShot 2025-06-12 at 11 07 16@2x

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review June 12, 2025 16:20
@kmcginnes kmcginnes requested a review from andreachild June 12, 2025 16:20
@kmcginnes kmcginnes merged commit 15b7f8f into aws:main Jun 12, 2025
2 checks passed
@kmcginnes kmcginnes deleted the fix-result-row-separator branch June 12, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separator sometimes doesn't show between each result

2 participants