chore: clean up repository root, shrinkwrap CLIs#696
Merged
Conversation
Move all files that don't need to be at the repository root under the dedicated sub-directory for those. This means all `.sh` files were moved under `scripts`. Some of those were also renamed, and the common uses have been aliased using `package.json` scripts (`npm run bootstrap`, `npm run build`, `npm run package`, ...). Additionally, ran `npm shrinkwrap` on the major CLIs (`jsii`, `jsii-diff`, `jsii-pacmak`) as a way to improve overall reliability.
eladb
approved these changes
Aug 12, 2019
Contributor
eladb
left a comment
eladb
left a comment
There was a problem hiding this comment.
wasn't shrinkwrapping superseded by package-lock files?
Contributor
|
Thank you for contributing! Your pull request is now being automatically merged. |
Contributor
Pull Request Checklist
|
Contributor
|
Thank you for contributing! Your pull request is now being automatically merged. |
Contributor
Author
|
@eladb - the shrink-wrap is packaged with the library, whereas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all files that don't need to be at the repository root under the
dedicated sub-directory for those. This means all
.shfiles were movedunder
scripts. Some of those were also renamed, and the common useshave been aliased using
package.jsonscripts (npm run bootstrap,npm run build,npm run package, ...).Additionally, ran
npm shrinkwrapon the major CLIs (jsii,jsii-diff,jsii-pacmak) as a way to improve overall reliability.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.