Skip to content

Conversation

@ccolon11
Copy link

Issue #496

Description of changes:
Replace Symphonia Lambda-Logging with Lambda Powertools

By submitting this pull request

  • [X ] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [X ] I confirm that I've made a best effort attempt to update all relevant documentation.

@deki
Copy link
Contributor

deki commented Apr 24, 2023

Thanks for your contribution. Have you compared the log output?
log4j2.xml probably needs to be changed so the Lambda request ID is still part of it.

I also see the dependency listed here https://github.com/awslabs/aws-serverless-java-container/blob/c9c573f71c38843012e1cc9c353810c65d0573a0/aws-serverless-springboot2-archetype/src/main/resources/archetype-resources/build.gradle#L13 and here https://github.com/awslabs/aws-serverless-java-container/blob/c9c573f71c38843012e1cc9c353810c65d0573a0/aws-serverless-jersey-archetype/src/main/resources/archetype-resources/build.gradle#L12.
Let's remove it there and just keep it as part of the samples.

@deki deki added this to the Release 2.0 milestone Apr 27, 2023
@ccolon11 ccolon11 closed this Apr 29, 2023
@ccolon11 ccolon11 deleted the replace-dependence-symphonia-lambda-logging branch April 29, 2023 01:21
@ccolon11 ccolon11 restored the replace-dependence-symphonia-lambda-logging branch April 29, 2023 01:21
@ccolon11 ccolon11 deleted the replace-dependence-symphonia-lambda-logging branch April 29, 2023 01:22
@ccolon11 ccolon11 restored the replace-dependence-symphonia-lambda-logging branch May 4, 2023 03:17
@ccolon11 ccolon11 deleted the replace-dependence-symphonia-lambda-logging branch May 5, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants