This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Fix the minimum memory reservation limitation for Docker change#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This update is relating to the Docker version change:
In the documentation for task definition parameter it is mentioning the minimum memory for different docker version for
memory, however, it did not point out the same constraint formemoryReservation:If trying to launch a task with
4mas minimum value ofmemoryReservation, it could be possible to get the following error when using Docker 20.10.0 or later:I also can verify this behavior with testing below:
Docker 20.10.7
Docker 19.03.13-ce
Description of changes:
Update the
memoryReservationto include minimum memory for different docker version.References:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.