Skip to content

fix(tools): fix cross-ref validator path handling and add to CI #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scoropeza wants to merge 1 commit into from
Closed

fix(tools): fix cross-ref validator path handling and add to CI #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,6 @@ jobs:

- name: Validate JSON manifests
run: mise run lint:manifests

- name: Validate cross-references
run: mise run lint:cross-refs
7 changes: 6 additions & 1 deletion tools/validate-cross-refs.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,14 @@ function validatePlugin(plugin) {
info(`Validating plugin: ${pluginName}`);

// Determine plugin directory path
// Source can be relative to repo root (./plugins/foo) or to plugins dir (./foo)
const source = plugin.source || `./${pluginName}`;
const normalizedSource = source.replace(/^\.\//, "").replace(/\/$/, "");
const pluginDir = path.join(PLUGINS_ROOT, normalizedSource);

// If source already includes plugins/ prefix, use as-is; otherwise prepend PLUGINS_ROOT
const pluginDir = normalizedSource.startsWith(`${PLUGINS_ROOT}/`)
? normalizedSource
: path.join(PLUGINS_ROOT, normalizedSource);

// Check 1: Plugin directory exists
if (!fs.existsSync(pluginDir)) {
Expand Down