Skip to content

Pass CRT error, if it exists, into completion function#563

Merged
bretambrose merged 3 commits intomainfrom
WebsocketHandshakeExceptions
May 6, 2024
Merged

Pass CRT error, if it exists, into completion function#563
bretambrose merged 3 commits intomainfrom
WebsocketHandshakeExceptions

Conversation

@bretambrose
Copy link
Copy Markdown
Contributor

@bretambrose bretambrose commented Apr 29, 2024

#562

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmklix jmklix linked an issue Apr 29, 2024 that may be closed by this pull request
2 tasks
@bretambrose bretambrose merged commit d76c3da into main May 6, 2024
@bretambrose bretambrose deleted the WebsocketHandshakeExceptions branch May 6, 2024 18:48
@NickDarvey
Copy link
Copy Markdown

Any chance of a new release of awscrt including this change @bretambrose? (And downstream into aws-iot-device-sdk-python-v2 too)

@bretambrose
Copy link
Copy Markdown
Contributor Author

Probably tomorrow with the correlation data fix merged

@bretambrose
Copy link
Copy Markdown
Contributor Author

bretambrose commented May 22, 2024

v1.21.5 of the SDK and v0.20.10 of the CRT have been released with this fix and several others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide more specific error for failures during MQTT WS handshake

3 participants