grep: warning: stray \ before -

[wknapik]

On commit, I get

grep: warning: stray \ before -

that's caused by the following pattern

% git config --get-all secrets.patterns|grep ACCOUNT                                                                                          
("|')?(AWS|aws|Aws)?_?(ACCOUNT|account|Account)_?(ID|id|Id)?("|')?\s*(:|=>|=)\s*("|')?[0-9]{4}\-?[0-9]{4}\-?[0-9]{4}("|')?
%

as demonstrated by

% grep -E "(\"|')?(AWS|aws|Aws)?_?(ACCOUNT|account|Account)_?(ID|id|Id)?(\"|')?\\s*(:|=>|=)\\s*(\"|')?[0-9]{4}\\-?[0-9]{4}\\-?[0-9]{4}(\"|')?"
grep: warning: stray \ before -
grep: warning: stray \ before -

This is on up-to-date Arch Linux and git-secrets 1.3.0 (the latest tag, from 3.5 years ago, which contains the latest master version of the git-secrets script).

[jeje232]

Hello,

Any new about this issue?
I have same problem with the 3.18.3 official Alpine docker image with the las grep upgrade.

Regards,

[LurkAndLoiter]

amazon id is 1234-5678-9012 (4#-4#-4#) dash - does not require an escape. backslash has no use there.

-{4}\\-?[0-9]{4}\\-?
+{4}-?[0-9]{4}-?

You can do this in a global setup by modifying the git config entry or you can do this in git-secrets: line 243

@@ 243 @@ git-secrets
-add_config 'secrets.patterns' "${opt_quote}${aws}(ACCOUNT|account|Account)_?(ID|id|Id)?${opt_quote}${connect}${opt_quote}[0-9]{4}\-?[0-9]{4}\-?[0-9]{4}${opt_quote}"
+add_config 'secrets.patterns' "${opt_quote}${aws}(ACCOUNT|account|Account)_?(ID|id|Id)?${opt_quote}${connect}${opt_quote}[0-9]{4}-?[0-9]{4}-?[0-9]{4}${opt_quote}"