Skip to content

Fix h5 early chunk improved iteration open#1

Merged
ax3l merged 10 commits intoax3l:fix-h5EarlyChunkfrom
franzpoeschel:fix-h5EarlyChunk-improved-iteration-open
Jul 20, 2021
Merged

Fix h5 early chunk improved iteration open#1
ax3l merged 10 commits intoax3l:fix-h5EarlyChunkfrom
franzpoeschel:fix-h5EarlyChunk-improved-iteration-open

Conversation

@franzpoeschel
Copy link

@franzpoeschel franzpoeschel commented Jul 15, 2021

This refactors and centralizes the routines for opening an iteration and its files, making it accessible for usage elsewhere. Use in availableChunks().

TODO:

@ax3l
Copy link
Owner

ax3l commented Jul 15, 2021

@franzpoeschel nice, thanks a lot! Shall I leave this open as you work on the to-do's? The overall concept looks good 👍

ICC seems to hang in 3/4 Test #3: Serial.SerialIO ..................***Timeout 1500.07 sec atm still.

@franzpoeschel franzpoeschel force-pushed the fix-h5EarlyChunk-improved-iteration-open branch from 1af7b73 to 2bdd25e Compare July 16, 2021 09:44
@franzpoeschel
Copy link
Author

@franzpoeschel nice, thanks a lot! Shall I leave this open as you work on the to-do's? The overall concept looks good +1

I'll update the documentation today, then I'd say we can merge this back with the original PR, so you won't have to push the CI manually each time (as long as you don't mind that I will then push to your branch).

ICC seems to hang in 3/4 Test #3: Serial.SerialIO ..................***Timeout 1500.07 sec atm still.

There's been a typecasting bug, maybe that was the reason.

@franzpoeschel
Copy link
Author

There's no central point in the documentation that documents Iteration::open() since the documentation is sorted not by API accesses, but by topic. It is mentioned at the two places where it is relevant:

  • In backendconfig.html to explain its interaction with defer_iteration_parsing.
  • In mpi.html to explain its interaction with collective file accesses.

I've added a note to streaming.html that it makes explicit use of Iteration::open() obsolete and extended the Doxy documentation to note all three use cases.

@franzpoeschel
Copy link
Author

Can you let the CI run again @ax3l? Otherwise, I think this is ready to go back to the original PR.

Copy link
Owner

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thank you! 🚀 ✨

@ax3l ax3l merged commit c315ff3 into ax3l:fix-h5EarlyChunk Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants