🔥 refactor: Make CBOR implementation follow MsgPack opt-in pattern#1
Draft
Copilot wants to merge 2 commits into
Draft
🔥 refactor: Make CBOR implementation follow MsgPack opt-in pattern#1Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: axrav <77937681+axrav@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor CBOR implementation to match MsgPack opt-in pattern
Description
Currently, CBOR support in Fiber is implemented with direct imports of the github.com/fxamacker/cbor/v2 library, while the new MsgPack implementation (PR #3565) uses an opt-in pa...
🔥 refactor: Make CBOR implementation follow MsgPack opt-in pattern
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactors the CBOR implementation to match the new MsgPack opt-in pattern, removing forced dependencies on rarely used serialization libraries and allowing users to choose their preferred CBOR library.
Problem
Currently, CBOR support in Fiber is implemented with direct imports of the
github.com/fxamacker/cbor/v2library:cbor.Marshalandcbor.Unmarshalas hardcoded defaultsSolution
Implements the same opt-in pattern used for MsgPack:
Before:
After:
User Configuration (opt-in):
Changes Made
Core Implementation
github.com/fxamacker/cbor/v2import fromapp.goUnimplementedCborMarshalandUnimplementedCborUnmarshalfunctions to binder packageTests
Error Handling
When users try to use CBOR without explicit setup, they get a helpful panic message:
Benefits
Migration Guide
For users currently using CBOR:
Testing
Related
Fixes: Addresses the inconsistency between CBOR and MsgPack serialization patterns
Closes: Related to discussions in gofiber#3565
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
exampleretry.com/tmp/go-build3680102919/b270/client.test -test.paniconexit0 -test.v=test2json -test.timeout=10m0s -test.count=1 -test.shuffle=on(dns block)/tmp/go-build142144758/b001/client.test -test.testlogfile=/tmp/go-build142144758/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s(dns block)/tmp/go-build1363832039/b001/client.test -test.testlogfile=/tmp/go-build1363832039/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.