"disabled_plugins" setting won't work for forked plugins

[YuCao16]

Version confirmation

• Confirm

Following prerequisites

• Confirm

Not a user config issue

• Confirm

Neovim version

NVIM v0.10.0-dev-618+g4fd852b8c

Operating system/version

Ubuntu 23.10

Terminal name/version

kitty 0.28.1

$TERM environment variable

xterm-kitty

Branch info

main (Default/Latest)

Fetch Preferences

SSH (use_ssh = true)

How to reproduce the issue

1. fork a plugin's repo, for example nvimdev/lspsaga.nvim as username/lspsaga.nvim, and add it to user/plugins/completion.lua, and in settings, add settings["disabled_plugins"] = {"nvimdev/lspsaga.nvim"}.
2. Restart neovim and run Lazy update
3. Enter neovim and run command Lspsaga xxx
4. It will return not a known command

Expected behavior

The nvimdev/lspsaga.nvim will be disabled, and I will use username/lspsaga.nvim.

Actual behavior

Lspsaga xxx is not a known command.

Additional information

This is not a problem of nvimdots actually, it related to lazy.nvim, as nvimdots use disable option to disable the plugin. However, lazy.nvim seems not support such situation. Maybe remove those disabled plugin from here?

nvimdots/lua/core/pack.lua

Lines 40 to 44 in f84f72d

	vim.list_extend(plugins_list, user_plugins_list)
	for _, f in ipairs(plugins_list) do
	-- aggregate the plugins from `/plugins/*.lua` and `/user/plugins/*.lua` to a plugin list of a certain field for later `require` action.
	-- current fields contains: completion, editor, lang, tool, ui
	list[#list + 1] = f:find(modules_dir) and f:sub(#modules_dir - 6, -1) or f:sub(#user_config_dir - 3, -1)

Let me known if you need more steps to reproduce!

[ayamir]

Can not understand the meaning of folded.
The problem is lazy.nvim store all plugins in ~/.local/share/nvim/site/lazy using just the plugin name (lspsaga.nvim) rather than with the author name (nvimdev/lspsaga.nvim). So it won't clone the forked repo because their names are the same.

[Jint-lzxy]

I think u should first do :Lazy clean (or <leader>px) without including any forks of the plugin in ur spec, and then :Lazy sync all plugins again (now with the fork u would like to include). As @ayamir mentioned, lazy.nvim will only use existing caches (located under ~/.cache/nvim/luac) when not explicitly asked to perform cleanup. But on the disk, plugins are distinguished only by their repo names (unless overwritten using the name field), so using two plugins with the same repo name without asking for (prior) explicit cleanup would confuse lazy.nvim.

[YuCao16]

Can not understand the meaning of folded. The problem is lazy.nvim store all plugins in ~/.local/share/nvim/site/lazy using just the plugin name (lspsaga.nvim) rather than with the author name (nvimdev/lspsaga.nvim). So it won't clone the forked repo because their names are the same.

Typo, sorry for the confusion.

[YuCao16]

I think u should first do :Lazy clean (or <leader>px) without including any forks of the plugin in ur spec, and then :Lazy sync all plugins again (now with the fork u would like to include). As @ayamir mentioned, lazy.nvim will only use existing caches (located under ~/.cache/nvim/luac) when not explicitly asked to perform cleanup. But on the disk, plugins are distinguished only by their repo names (unless overwritten using the name field), so using two plugins with the same repo name without asking for (prior) explicit cleanup would confuse lazy.nvim.

Seems not work. I understand the way lazy.nvim deal with plugin with enabled = false. Can we just remove those disabled plugins by remove them from plugins_list instead of using enabled opt?

[ayamir]

#1079 (comment)