fix(rust): respect user configs #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does three things: - Allows users to overwrite the init options of `rustaceanvim` thru their custom configs; - It gives a heads-up to users that if they're still manually setting up `rust_analyzer`, this will result in two identical servers being spawned; - DAP-related settings are disabled by default to avoid potential conflicts with previous user configurations. IMO since we already have configs for `codelldb` that can be used, users can simply tweak those configs on their own. But I'm not 2 sure about this, as I personally don't do much rust development. What do u guys think?
ClSlaid
approved these changes
Jan 10, 2024
ayamir
approved these changes
Jan 10, 2024
ttbug
pushed a commit
to ttbug/nvimconf
that referenced
this pull request
Jan 12, 2024
This PR does three things: - Allows users to overwrite the init options of `rustaceanvim` thru their custom configs; - It gives a heads-up to users that if they're still manually setting up `rust_analyzer`, this will result in two identical servers being spawned; - DAP-related settings are disabled by default to avoid potential conflicts with previous user configurations. IMO since we already have configs for `codelldb` that can be used, users can simply tweak those configs on their own. But I'm not 2 sure about this, as I personally don't do much rust development. What do u guys think?
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Jan 14, 2024
This PR does three things: - Allows users to overwrite the init options of `rustaceanvim` thru their custom configs; - It gives a heads-up to users that if they're still manually setting up `rust_analyzer`, this will result in two identical servers being spawned; - DAP-related settings are disabled by default to avoid potential conflicts with previous user configurations. IMO since we already have configs for `codelldb` that can be used, users can simply tweak those configs on their own. But I'm not 2 sure about this, as I personally don't do much rust development. What do u guys think?
|
I use the current master branch, and I also have two rust-analyzer LSP server, I don't get the WARN notification this pr add, please help, how can I solve this 
|
|
after I remove rust_analyzer.lua in lsp-nvimconfig plugin, it works, only one LSP server left for rust buffer, I have no idea: |
Collaborator
|
@CharlesChiuGit thanks for your feed back, I have backport the pr you mentioned a couple dayes ago, still don't work. or is there a command or operation needed to make new config work after changing config? |
Collaborator
|
@yyb196 had u do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
Allows users to overwrite the init options of
rustaceanvimthru their custom configs;It gives a heads-up to users that if they're still manually setting up
rust_analyzer, this will result in two identical servers being spawned;DAP-related settings are disabled by default to avoid potential conflicts with previous user configurations. IMO since we already have configs for
codelldbthat can be used, users can simply tweak those configs on their own. But I'm not 2 sure about this, as I personally don't do much rust development. What do u guys think @ClSlaid @CharlesChiuGit @ayamir?