-
Notifications
You must be signed in to change notification settings - Fork 482
Improve nixos #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nixos #1212
Conversation
71e1b4a to
9375041
Compare
9375041 to
833fdcb
Compare
|
Thanks for your continuous contributions! I don't have |
dependencies are consolidated into one buildEnv this is not placed under the user env and are resolved with a direct path to /nix/store respect environment variables such as PKG_CONFIG_PATH if they are already set
| name = "nvim-depends-pkgconfig"; | ||
| paths = splitString ":" (makePkgConfigPath build-dependent-pkgs); | ||
| extraPrefix = "/lib/nvim-depends/pkgconfig"; | ||
| neovim-build-deps = pkgs.buildEnv { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qq: why do we have to build neovim from scratch again?
Can we utilize something like neovim-nightly or sth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can add that, but i'm half way on completing my nix config.
i'll check this pr once i'm done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg. I have yet to migrate all my neovim to nix yet so haven't tested it extensively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess i'm wrong, it's not the same as adding overlays in home manager's home.nix.
|
Does this PR work as expect? |
an option to specify additional arguments has been added to neovim.wrapper, so change to use it however, since that option does not exist in versions prior to 24.05, the traditional method will remain
|
I have confirmed that it works in at least NixOS/zsh environment. |
|
@misumisumi |
|
This is a little difficult when using dotnet in a NIX environment, so we made it modular to make it easier to configure. |
* feat!: replace nixosModules to homeManagerModules * feat: support bind lazy-lock.json * style: formatter * chore(lockfile): auto update lazy-lock.json * refactor(nixos): better dependency resolution dependencies are consolidated into one buildEnv this is not placed under the user env and are resolved with a direct path to /nix/store respect environment variables such as PKG_CONFIG_PATH if they are already set * refactor(nixos/neovim): refactor adding buildDeps an option to specify additional arguments has been added to neovim.wrapper, so change to use it however, since that option does not exist in versions prior to 24.05, the traditional method will remain --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
#1211
lazy-config.jsonunder.config/nvimnixosModulestohomeManagerModules(BREAKING CHANGE)