Skip to content

Conversation

@misumisumi
Copy link
Collaborator

#1211

  • Support for placing lazy-config.json under .config/nvim
  • Change from nixosModules to homeManagerModules (BREAKING CHANGE)

@ayamir
Copy link
Owner

ayamir commented Mar 31, 2024

Thanks for your continuous contributions! I don't have nix or nixos environment so can't test it. Could you please check it? @aarnphm @CharlesChiuGit

dependencies are consolidated into one buildEnv
this is not placed under the user env and are resolved with a direct path to /nix/store
respect environment variables such as PKG_CONFIG_PATH if they are already set
name = "nvim-depends-pkgconfig";
paths = splitString ":" (makePkgConfigPath build-dependent-pkgs);
extraPrefix = "/lib/nvim-depends/pkgconfig";
neovim-build-deps = pkgs.buildEnv {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: why do we have to build neovim from scratch again?

Can we utilize something like neovim-nightly or sth?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can add that, but i'm half way on completing my nix config.
i'll check this pr once i'm done.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg. I have yet to migrate all my neovim to nix yet so haven't tested it extensively.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess i'm wrong, it's not the same as adding overlays in home manager's home.nix.

@ayamir
Copy link
Owner

ayamir commented Apr 20, 2024

Does this PR work as expect?

an option to specify additional arguments has been added to neovim.wrapper, so change to use it
however, since that option does not exist in versions prior to 24.05, the traditional method will remain
@misumisumi
Copy link
Collaborator Author

I have confirmed that it works in at least NixOS/zsh environment.

@ayamir ayamir linked an issue Apr 20, 2024 that may be closed by this pull request
@ayamir ayamir requested review from aarnphm and charliie-dev April 20, 2024 10:21
@charliie-dev
Copy link
Collaborator

charliie-dev commented Apr 22, 2024

@misumisumi
why do we need to include dotnet? is that necessary?
besides that, i'm cool w/ the rest parts.

@misumisumi
Copy link
Collaborator Author

misumisumi commented Apr 23, 2024

This is a little difficult when using dotnet in a NIX environment, so we made it modular to make it easier to configure.
Actually, there is a procedure in NixOSWiki/DotNET, so there is no problem even if it is not included here.

@charliie-dev charliie-dev merged commit e798793 into ayamir:main Apr 23, 2024
@misumisumi misumisumi deleted the improve-nixos branch July 2, 2024 07:49
Deg2v pushed a commit to Deg2v/nvimdots that referenced this pull request Jan 16, 2025
* feat!: replace nixosModules to homeManagerModules

* feat: support bind lazy-lock.json

* style: formatter

* chore(lockfile): auto update lazy-lock.json

* refactor(nixos): better dependency resolution

dependencies are consolidated into one buildEnv
this is not placed under the user env and are resolved with a direct path to /nix/store
respect environment variables such as PKG_CONFIG_PATH if they are already set

* refactor(nixos/neovim): refactor adding buildDeps

an option to specify additional arguments has been added to neovim.wrapper, so change to use it
however, since that option does not exist in versions prior to 24.05, the traditional method will remain

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve NixOS support

4 participants