feat: auto compile before debug (#1367). #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ayamir <lgt986452565@gmail.com>
Signed-off-by: ayamir <lgt986452565@gmail.com>
Owner
Author
Collaborator
|
seems reasonable for me, but i'm currently busy so i can't test it. |
|
However, the default output path of Debug should also be changed to ./filename.out. Now the default is ./a.out, and the compiled binary file is ./filename.out |
Owner
Author
Done |
|
It works great, thanks a lot |
Deg2v
pushed a commit
to Deg2v/nvimdots
that referenced
this pull request
Jan 16, 2025
* feat: auto compile before debug (ayamir#1367). * fix: ci. * fix: ci. * fix: keep filename consistency with compiled outfile and prompt. --------- Signed-off-by: ayamir <lgt986452565@gmail.com>
Jint-lzxy
added a commit
that referenced
this pull request
Jan 18, 2025
This PR reverts commit a1c76b2. The main rationale behind this is IMO the current implementation of this function has several limitations that need to be addressed: 1. It works with only a single file, which is not typical for most use cases 2. It only supports gcc as the compiler, whereas other compilers (most notably clang, xlc, cl.exe and friends) are not supported 3. There's no way to control compile and/or build flags. 4. File type detection is too restrictive and doesn't cover all cases (using vim's ftplugins may be more effective) and 5. Violating any of these assumptions results in errors, rendering this keymap completely ineffective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1367