fix(lualine): resolve background color defaulting issue #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the root cause of #1381 by allowing lualine to automatically select the default background color. Previously, lualine attempted to retrieve the background manually, which could lead to issues when querying in a different namespace (and resulting in an empty dictionary). Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
9 tasks
ayamir
approved these changes
Apr 5, 2025
Owner
ayamir
left a comment
ayamir
left a comment
There was a problem hiding this comment.
LGTM, I find the colorscheme of bufferline is also won't change when switching to a new colorscheme.
ayamir
added a commit
that referenced
this pull request
Apr 20, 2025
* feat(options): make omnifunc support fuzzy matching (#1441) Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com> * feat(treesitter): remove performance limitations (#1442) This commit removes all previous performance restrictions as treesitter now supports full asynchronous parsing. Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com> * fix(lualine): resolve background color defaulting issue (#1443) This commit addresses the root cause of #1381 by allowing lualine to automatically select the default background color. Previously, lualine attempted to retrieve the background manually, which could lead to issues when querying in a different namespace (and resulting in an empty dictionary). Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com> * fix(keymap): prevent new builtins from interfering with our keymap (#1444) This commit prevents lag when using `gr` by avoiding conflicts with new keymaps Neovim defines with this prefix. Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com> * feat: support virtual_line and adapt to the latest diagnostics interface. (#1447) * feat: add setting entry for virtual lines. * fix: hide or show virtual text and lines instead of diagnostics itself. * fix: correct comment. * fix: restore comment note. * fix: toggle inlay hints correctly. (#1449) * fix: toggle inlay hints correctly. Previous impl won't work when toggle for the first time. * fix: toggle for all buffers. * fix: replace project.nvim with newest apis. (#1450) * feat: add garbage-dev to save memory for inactive lsp. * fix: remove underline for diagnostics. * Revert "feat: add garbage-dev to save memory for inactive lsp." This reverts commit 0ccac94. * Revert "fix: remove underline for diagnostics." This reverts commit bb1d274. * feat: use tiny inline diagnostics to manage virtual text. (#1452) * feat: add tiny inline diagnostic. * refactor: disable virtual text by default. --------- Signed-off-by: Charles Chiu <charleschiu@hey.com> Co-authored-by: Charles Chiu <charleschiu@hey.com> --------- Signed-off-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com> Signed-off-by: Charles Chiu <charleschiu@hey.com> Co-authored-by: jint_lzxy_ <50296129+Jint-lzxy@users.noreply.github.com> Co-authored-by: Charles Chiu <charleschiu@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the root cause of #1381 by allowing lualine to automatically select the default background color. Previously, lualine attempted to retrieve the background manually, which could lead to issues when querying in a different namespace (and resulting in an empty dictionary).