Skip to content

Assignment 2#2

Open
ayeshagrr wants to merge 3 commits intomainfrom
assignment-2
Open

Assignment 2#2
ayeshagrr wants to merge 3 commits intomainfrom
assignment-2

Conversation

@ayeshagrr
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one change.
Question 3: The train test split asked for is 75 - 25. You have used train_size=0.25 which makes train set 25% instead of 75%

@anjali-deshpande-hub
Copy link
Copy Markdown

A gentle reminder to complete the requested review changes. Thanks!

@anjali-deshpande-hub
Copy link
Copy Markdown

Looks good! Except that you need to run the cell again to see the updated results. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants