Handle missing recitation subtask IDs

[azalio]

Summary

• validate that RecitationManager.update_subtask_status locates the requested subtask before updating it
• reuse the located subtask when logging status updates to avoid stale references
• update the edge-case test to expect a ValueError when a subtask id is missing

Testing

• pytest tests/test_recitation_manager.py::TestEdgeCases::test_update_nonexistent_subtask -q (fails: ModuleNotFoundError: mapify_cli)

---

https://chatgpt.com/codex/tasks/task_e_68f713d262e08324b764075e2b91c6f6

[Copilot]

Pull Request Overview

This PR improves error handling in the RecitationManager.update_subtask_status method by ensuring that subtask IDs are validated before attempting updates. The key changes include:

• Adding upfront validation to raise a ValueError when a non-existent subtask ID is provided
• Refactoring to use a single located subtask reference throughout the method to prevent stale references
• Updating the test expectations to verify that the method now raises an error for missing subtask IDs

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/mapify_cli/recitation_manager.py	Refactored update_subtask_status to validate subtask existence upfront and use a single reference for all operations
tests/test_recitation_manager.py	Updated test to expect ValueError when updating a non-existent subtask instead of silently failing

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The error message format is inconsistent with the test expectation. The test expects the pattern 'Subtask with id 999' but the message includes 'was not found in the current plan' which may not match. Consider simplifying to match the test pattern exactly, or update the test to match the full message.

Suggested change

	f"Subtask with id {subtask_id} was not found in the current plan"
	f"Subtask with id {subtask_id}"