Refactor AHBot command passing#85
Merged
Helias merged 2 commits intoazerothcore:masterfrom May 10, 2024
Merged
Conversation
Helias
reviewed
May 9, 2024
Co-authored-by: Stefano Borzì <stefanoborzi32@gmail.com>
Helias
approved these changes
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the way commands are passed.
Instead of passing a magic number and writing a comment of what it means, pass an enum.
Instead of copy-pasting the quality level parsing code, make it a lambda function.
This could still be done much cleaner, but its a first step.
It should be refactored to use command tables, some other time.