Skip to content

[TASK] make ci happy #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achimfritz merged 4 commits into from
Nov 24, 2025
Merged

[TASK] make ci happy #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe8076e
[TASK] phpstan for TYPO3 14
achimfritz Nov 18, 2025
4a0476c
[TASK] acceptance tests
achimfritz Nov 18, 2025
02af11e
[TASK] disable v11 acceptance tests
achimfritz Nov 22, 2025
45439ef
[TASK] make v13 acceptance tests running again
achimfritz Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

- name: Acceptance Tests
run: Build/Scripts/runTests.sh -p ${{ matrix.php }} -t ${{ matrix.TYPO3 }} -s acceptance -- --fail-fast
if: matrix.TYPO3 != '14'
if: matrix.TYPO3 != '11' && matrix.TYPO3 != '14'

- name: Archive acceptance tests results
uses: actions/upload-artifact@v4
Expand Down
3 changes: 2 additions & 1 deletion Build/Scripts/runTests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@ IMAGE_PHP="ghcr.io/typo3/core-testing-$(echo "php${PHP_VERSION}" | sed -e 's/\./
IMAGE_NODEJS="ghcr.io/typo3/core-testing-nodejs18:latest"
IMAGE_NODEJS_CHROME="ghcr.io/typo3/core-testing-nodejs18-chrome:latest"
IMAGE_ALPINE="docker.io/alpine:3.8"
IMAGE_SELENIUM="docker.io/selenium/standalone-chrome:4.11.0-20230801"
# HEADS UP: We need to pin to <132 for --headless=old support until https://issues.chromium.org/issues/362522328 is resolved
IMAGE_SELENIUM="docker.io/selenium/standalone-chromium:131.0-20250101"
IMAGE_MARIADB="docker.io/mariadb:${DBMS_VERSION}"
IMAGE_MYSQL="docker.io/mysql:${DBMS_VERSION}"
IMAGE_POSTGRES="docker.io/postgres:${DBMS_VERSION}-alpine"
Expand Down
1 change: 1 addition & 0 deletions Build/phpstan14.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ parameters:
- %currentWorkingDirectory%/Classes/ContentDefender
- %currentWorkingDirectory%/Classes/Events/BeforeContainerPreviewIsRenderedEvent.php
- %currentWorkingDirectory%/Tests/Functional/Integrity/IntegrityTest.php
- %currentWorkingDirectory%/Classes/Xclasses/LocalizationController.php

2 changes: 1 addition & 1 deletion Tests/Acceptance/Support/PageTreeV13.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ protected function ensureTreeNodeIsOpen(string $nodeText, RemoteWebElement $cont
});

try {
$context->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('.node-toggle > typo3-backend-icon[identifier=\'actions-chevron-right\']'))->click();
$context->findElement(\Facebook\WebDriver\WebDriverBy::cssSelector('.node-toggle > typo3-backend-icon[identifier=\'actions-chevron-end\']'))->click();
} catch (\Facebook\WebDriver\Exception\NoSuchElementException $e) {
// element not found so it may be already opened...
} catch (\Facebook\WebDriver\Exception\ElementNotVisibleException $e) {
Expand Down
7 changes: 5 additions & 2 deletions Tests/codeception.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ modules:
port: 9515
path: /
# @todo: adapt tests to not break with a defined window size (as in v12/v13)
#window_size: 1280x1024
window_size: 1280x1024
capabilities:
goog:chromeOptions:
args: ["window-size=1280,1024"]

env:
ci:
Expand Down Expand Up @@ -54,4 +57,4 @@ env:
args: ["no-sandbox", "disable-gpu"]
params:
- parameters.yml
- env
- env
Loading