Skip to content

[BUGFIX] Avoid invalidation when calling set on the cache backend #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmack merged 1 commit into from
Oct 9, 2023
Merged

[BUGFIX] Avoid invalidation when calling set on the cache backend #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Classes/Cache/Backend/ReverseProxyCacheBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,18 +74,18 @@ public function setReverseProxyEndpoints($endpoints = null)
* Removes all cache entries matching the specified identifier.
* Usually this only affects one entry.
*
* Please note: As remove() is called when using set() in the parent method,
* it would also flush the cache when the FE is accessed, resulting in a lot of
* cache entries. This should be avoided, for this reason, we do not call the
* provider anymore. Ideally we should not invalidate but rather push this actively
* to the proxy in the future.
*
* @param string $entryIdentifier Specifies the cache entry to remove
*
* @return bool TRUE if (at least) an entry could be removed or FALSE if no entry was found
*/
public function remove($entryIdentifier)
{
// call the provider to forget this URL
$url = $this->get($entryIdentifier);
if ($url) {
$this->reverseProxyProvider->flushCacheForUrl($url);
}

return parent::remove($entryIdentifier);
}

Expand Down