Skip to content

format-table now formats multiline cells#120

Merged
borkdude merged 2 commits intobabashka:mainfrom
lread:lread/multiline-cells
Apr 14, 2025
Merged

format-table now formats multiline cells#120
borkdude merged 2 commits intobabashka:mainfrom
lread:lread/multiline-cells

Conversation

@lread
Copy link
Contributor

@lread lread commented Apr 13, 2025

Closes #119

@lread
Copy link
Contributor Author

lread commented Apr 13, 2025

I'm assuming the first row in the table is an ok place to determine the number of columns in the table. Seems ok to me, but thought I'd mention it just in case.

I also got rid of eagerness and stayed lazy which seems to match other
code here.
@lread
Copy link
Contributor Author

lread commented Apr 14, 2025

Does that feel better? Lemme know, happy to tweak further.

@borkdude borkdude merged commit 72e7bd4 into babashka:main Apr 14, 2025
10 checks passed
@borkdude
Copy link
Contributor

Thanks!

@lread
Copy link
Contributor Author

lread commented Apr 14, 2025

My pleasure. Are you ok with doing another release? I could use this to simplify my antq PR.

@borkdude
Copy link
Contributor

Yep! Coming up

@lread
Copy link
Contributor Author

lread commented Apr 14, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Any interest in supporting multiline cells in usage help?

2 participants