Skip to content

Comments

Allow Puma 7.0#35

Open
Ruto8 wants to merge 1 commit intobabbel:mainfrom
Ruto8:pr-puma-7.0
Open

Allow Puma 7.0#35
Ruto8 wants to merge 1 commit intobabbel:mainfrom
Ruto8:pr-puma-7.0

Conversation

@Ruto8
Copy link

@Ruto8 Ruto8 commented Sep 9, 2025

Here's a link to the Puma 7.0 release which mentions breaking changes. Based on my quick analysis, these don't impact the puma-plugin-telemetry gem, so I'm bumping the Puma support in this gem.

Since this is blocking our upgrade to Puma 7.0, I'd also appreacing releasing a new version of puma-plugin-telemetry 🙏

stevenharman added a commit to stevenharman/puma-plugin-telemetry_too that referenced this pull request Sep 19, 2025
Until babbel#35 is merged, we need to hack in our own Puma 7 support.
babbel#35

Similarly, this has a hack for babbel#23 so we can run tests on macOS.
babbel#23
@stevenharman
Copy link
Contributor

We also made this tweak in our fork of puma-plugin-telemetry and are now testing it against Puma 7. So far, so good!

@butsjoh
Copy link

butsjoh commented Sep 22, 2025

👍 please approve the bump :)

stevenharman added a commit to stevenharman/puma-plugin-telemetry_too that referenced this pull request Sep 23, 2025
Until babbel#35 is merged, we need to hack in our own Puma 7 support.
babbel#35

Similarly, this has a hack for babbel#23 so we can run tests on macOS.
babbel#23
@stevenharman
Copy link
Contributor

Note that just bumping the constraint on Puma will cause test failures for the socket stats-related tests (only apply to certain Linux kernels) as the internals of Puma 7 have changed significantly such that the tests as written cannot overwhelm the socket. I've started a conversation with Puma maintainers to see if they have ideas about how we might change the tests to be reliable/pass with Puma 7.

@butsjoh
Copy link

butsjoh commented Oct 28, 2025

Seems this project is dead cause nobody is actively doing anything here. We cannot use forks cause we are not allowed to run git to checkout gems nor are we allowed to vendor code. We are going to look at other gems or integrations that make this work.

@stevenharman
Copy link
Contributor

@butsjoh FWIW, we've forked, renamed (slightly), and published a new gem: https://rubygems.org/gems/puma-plugin-telemetry_too

We have been running this in production for over a week. When I get a chance I'm going to bump that to a proper v1.0 and push a new Gem version. It includes the Puma 7 changes, and the changes we needed/wanted for additional metrics targets, formatters, etc… My hope is that all of those changes will be accepted upstream (here, this Gem) and we can then switch back. But until then, we're forced to run the forked gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants