Add schema validation#822
Merged
Merged
Conversation
Contributor
Author
|
What should be done to get it merged @JLHwung ? |
Contributor
|
Hi @ogonkov, generally we have two-approval policy on merging PRs. Let's wait for a longer while. Thanks for your patience. |
Contributor
Author
|
@JLHwung Can we invite someone here to review? |
This was referenced Mar 29, 2020
This was referenced Apr 11, 2020
This was referenced Apr 23, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Options is validated programmatically
What is the new behavior?
Options validated through schema, webpack will assist if given option is not match schema
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information:
Closes #749