Improve using declaration errors#17333
Merged
Merged
Conversation
JLHwung
added
PR: Polish 💅
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59504 |
nicolo-ribaudo
approved these changes
May 26, 2025
| this.match(tt._var) || | ||
| this.isLet() || | ||
| (this.hasPlugin("explicitResourceManagement") && | ||
| ((this.isContextual(tt._using) && this.startsUsing()) || |
Member
There was a problem hiding this comment.
Nit: could we move the this.isContextual(tt._using) inside this.startsUsing() (and maybe rename it to isUsing, similar to isLet)? Just because we are checking this.isContextual(tt._using) first every time we call this.startsUsing() anyway.
Contributor
Author
There was a problem hiding this comment.
okay, we often call startsUsing in a big switch case so isContextual would introduce a duplicate using token check. But it probably has little impact on the performance.
JLHwung
force-pushed
the
improve-using-declaration-errors
branch
from
1672fe9 to
6efb2d9
Compare
nicolo-ribaudo
approved these changes
May 29, 2025
JLHwung
force-pushed
the
improve-using-declaration-errors
branch
from
c4af333 to
06e3516
Compare
|
|
||
| case tt._await: | ||
| // [+Await] await [no LineTerminator here] using [no LineTerminator here] BindingList[+Using] | ||
| if (!this.state.containsEsc && this.startsAwaitUsing()) { |
Member
There was a problem hiding this comment.
startsAwaitUsing seems to have no reference anymore, let's remove it?
liuxingbaoyu
approved these changes
May 31, 2025
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
export default using xand TSdeclare using x.